Repository navigation
Improve the ACL matching algorithm - #214
Conversation
|
All is well |
There was a problem hiding this comment.
Why are these wrapped in debug.enabled?
There was a problem hiding this comment.
I think it's a good practice to check the flag to avoid any calculations such as string concatenation on the parameters of the debug().
There was a problem hiding this comment.
Ah sure. But all of those are O(1)... so a bit premature optimization IMO. Not worried about it just curious.
|
Only a couple minor comments. Overall I'm assume this catches an odd case in the weighting algorithm. To improve this we should document the algorithm a bit more clearly and so a user can easily understand it. I also think we really need the ability to drop down into a simple function based access control. Perhaps should be the base for ACL2. |
|
All is well |
|
LGTM 👍 |
Improve the ACL matching algorithm
/to @ritch
See strongloop/loopback-example-access-control#8